Some fixes from me to Tristan v1.0.0g4

  1. 5 years ago
    Edited 5 years ago by Firestarter

    Hello.
    I downloaded Tristan's 1.0.0g4 and found some little bugs in it. Maybe my solutions will be useful to you:
    Attachmen plugin
    If plugin is installed, conversations deletes perfectly, but if not, we have some errors. Go to \core\models\ETConversationModel.class.php
    find:

    			$rows = ET::SQL()
    				->select("a.attachmentId")
    				->from("attachment a")
    				->from("post p", "a.postId=p.postId", "left")
    				->where("p.conversationId=$id")->exec()->allRows();
    			$amodel = ET::getInstance("attachmentModel");
    
    			if ($amodel) {
    				foreach ($rows as $row) {
    					$aid = $row["attachmentId"];
    					$attachment = $amodel->getById($aid);
    					$amodel->deleteById($aid);
    					@unlink($amodel->path().$aid.$attachment["secret"]);
    					@unlink($amodel->path().$aid.$attachment["secret"]."_thumb");
    				}
    			}

    and replace:

    if(array_search('Attachments', C("esoTalk.enabledPlugins"))){
    			$rows = ET::SQL()
    				->select("a.attachmentId")
    				->from("attachment a")
    				->from("post p", "a.postId=p.postId", "left")
    				->where("p.conversationId=$id")->exec()->allRows();
    			$amodel = ET::getInstance("attachmentModel");
    
    			if ($amodel) {
    				foreach ($rows as $row) {
    					$aid = $row["attachmentId"];
    					$attachment = $amodel->getById($aid);
    					$amodel->deleteById($aid);
    					@unlink($amodel->path().$aid.$attachment["secret"]);
    					@unlink($amodel->path().$aid.$attachment["secret"]."_thumb");
    				}
    			}
    		
    		}

    ClearURLS for Latin,Greek,Turkish,Russian,Ukrainian,Czech,Polish and Latvian.
    Go \core\lib\functions.general.php
    And change slug function to:
    View
    Litle more complit Russian translation. Nearly all strings translated
    Download
    If I find any errors yet, I'll try to fix them and putting them on community forum. I dont knov how to use Git push)))
    Sorry for my bad English))

  2. Thanks! I will go over the changes and add them to the development branch soon. I will also add the Russian translation to the esoTalk-languages collection repository!

  3. If you found more issues, please submit an issue over at GitHub at the corresponding repositories.

    My esoTalk fork
    The plugins repository collection
    The language repository collection
    The skins repository collection

  4. Thanks, Tristan.
    P.S.: I can "Like" my own post)))

  5. Russian translation have been added: https://github.com/esoTalk-languages/Russian

  6. Edited 5 years ago by Tristan

    I cannot find this line:

    $key = array_search('green', $array);

    in core\models\ETConversationModel.class.php or anywhere else in my repo.

  7. Sorry, without this line)))
    Я могу вам задавать вопросы на русском?

  8. @Firestarter Я могу вам задавать вопросы на русском?

    I had to Google Translate your question :)
    No, I'm sorry I don't understand Russian.

  9. I've been away for a while and I'm pleased to see esoTalk still alive thanks the contribute of people like @Tristan (very active!) and @Firestarter.

    I have an old phpBB2 forum that I'm going to open again (after three years of stop) and I was migrating it to Vanilla2 but, if esoTalk is still a real option, I'd prefer it.

    The "chrono-links" on the right, for example, would be great for users to navigate between years.

    Good luck and thanks for all your precious work, guys!

  10. @candyman I have good faith in esoTalk. We should develop some migration scripts for phpBBx, Vanilla, etc..

  11. Edited 5 years ago by candyman

    Can't wait for it!
    Please consider that one thing is often missing with the porters I've tried in the past is the fact the the porting isn't complete.
    I've tried to migrate my forum and, even if the thread and posts were OK, some things like polls were missing.
    Is there some poll plugin for esoTalk out there?

  12. There is no poll plugin available yet, but it is on my todo list.

  13. Hi @Tristan, is there a lot of bugs fix on your v1.0.0g4? Should i update it? Right now i'm still using Toby's g3. Thanks.

  14. Edited 5 years ago by Tristan

    I recommend you to hold on to g3 for the moment.. I have a meeting with @Toby next week and we are probably going to merge back most of my changes back into the original repository. If that is done I will discard my project and continue to develop on the original repository instead. I will let you know by then!

 

or Sign Up to reply!