Attachment removal handling duplicate code?

  1. 5 years ago
    Edited 5 years ago by Tristan

    @Toby In regards of #172 and me submitting pull requests instead now, I was going over the attachment removal handling again. One thing I don't understand is why the core code needs attachment removal handling (see here , here ) as well as in the plugin . Is there a way where we can do a callback to the plugin instead so attachment handling lives only there?

    The other thing I don't understand is that the $model->deleteById and $model->getById functions are missing in action completely. Now @peter mentioned in this discussion that those functions are used from another place. And that removal was working for him. But I don't see how. Can you please elaborate where those function would be and how it would work without those functions?

    ps. I have wrote those 2 functions earlier and got it working, I just want the be sure they are really needed.

  2. Might want to continue this discussion on GitHub

 

or Sign Up to reply!