best solution to disable inline-block style of popupWrapper?

  1. 5 years ago
    Edited 5 years ago by Tristan

    @Toby would this be the best solution to disable the default inline-block style for popupWrapper class? With the addition to the Share plugin committed here and here .

    Is is needed the counter the following behavior when scrolling below the fold
    Screen Shot 2014-04-16 at 23.28.31.png

    In this case the best solution is a necessary tweak to base.css (see 9d97d0f ). However your addition to the popup function is good — could you please submit a pull request for that commit?

    P.S. Please make sure your editor is set to use tabs instead of spaces, in keeping with the rest of the esoTalk code.

  2. Toby

    17 Apr 2014 Administrator Answer

    In this case the best solution is a necessary tweak to base.css (see 9d97d0f ). However your addition to the popup function is good — could you please submit a pull request for that commit?

    P.S. Please make sure your editor is set to use tabs instead of spaces, in keeping with the rest of the esoTalk code.

  3. I will try to sumbit a pull request for that specific commit later today but it might not be possible. See

  4. Pull request is up, unfortunately not with the specific commit

 

or Sign Up to reply!